Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
EvaP
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
CourseEval
EvaP
Commits
4315afff
Unverified
Commit
4315afff
authored
Nov 1, 2021
by
fidoriel
Committed by
GitHub
Nov 1, 2021
Browse files
Options
Downloads
Patches
Plain Diff
fix #1606 (#1659)
fix #1606: Don't show buttons to pages the users are not allowed to access.
parent
78d18883
No related branches found
No related tags found
No related merge requests found
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
evap/staff/templates/staff_semester_view.html
+25
-19
25 additions, 19 deletions
evap/staff/templates/staff_semester_view.html
evap/staff/templates/staff_semester_view_evaluation.html
+1
-1
1 addition, 1 deletion
evap/staff/templates/staff_semester_view_evaluation.html
with
26 additions
and
20 deletions
evap/staff/templates/staff_semester_view.html
+
25
−
19
View file @
4315afff
...
...
@@ -154,12 +154,14 @@
<div
class=
"tab-pane show active"
id=
"evaluations"
role=
"tabpanel"
>
<div
class=
"row align-items-center mb-3"
>
<div
class=
"col-9"
>
{% if request.user.is_manager %}
<a
class=
"btn btn-sm btn-dark"
href=
"{% url 'staff:evaluation_create' semester.id %}"
>
{% trans 'Create evaluation' %}
</a>
<a
class=
"btn btn-sm btn-dark ms-2"
href=
"{% url 'staff:single_result_create' semester.id %}"
>
{% trans 'Create single result' %}
</a>
{% endif %}
</div>
<div
class=
"col-3"
>
<div
class=
"input-group"
>
...
...
@@ -333,9 +335,11 @@
<div
class=
"tab-pane"
id=
"courses"
role=
"tabpanel"
>
<div
class=
"row align-items-center mb-3"
>
<div
class=
"col-9"
>
{% if request.user.is_manager %}
<a
class=
"btn btn-sm btn-dark"
href=
"{% url 'staff:course_create' semester.id %}"
>
{% trans 'Create course' %}
</a>
{% endif %}
</div>
<div
class=
"col-3"
>
<div
class=
"input-group"
>
...
...
@@ -385,6 +389,7 @@
{% endif %}
</td>
<td
class=
"icon-buttons"
>
{% if request.user.is_manager %}
<a
class=
"btn btn-sm btn-dark"
data-bs-toggle=
"tooltip"
href=
"{% url 'staff:evaluation_create' semester.id course.id %}"
title=
"{% trans "
Create
evaluation
for
this
course
"
%}"
>
...
...
@@ -395,6 +400,7 @@
title=
"{% trans "
Create
single
result
for
this
course
"
%}"
>
<span
class=
"fas fa-poll"
></span>
</a>
{% endif %}
{% if course.can_be_deleted_by_manager %}
<button
type=
"button"
onclick=
"deleteCourseModalShow({{ course.id }}, '{{ course.name|escapejs }}');"
class=
"btn btn-sm btn-outline-danger"
data-bs-toggle=
"tooltip"
data-bs-placement=
"top"
title=
"{% trans 'Delete' %}"
>
<span
class=
"fas fa-trash"
aria-hidden=
"true"
></span>
...
...
This diff is collapsed.
Click to expand it.
evap/staff/templates/staff_semester_view_evaluation.html
+
1
−
1
View file @
4315afff
...
...
@@ -184,7 +184,7 @@
{% endif %}
<td
class=
"icon-buttons"
>
{% if not info_only %}
{% if not evaluation.is_single_result %}
{% if not evaluation.is_single_result
and request.user.is_manager
%}
<a
href=
"{% url 'staff:evaluation_copy' semester.id evaluation.id %}"
class=
"btn btn-sm btn-light"
data-bs-toggle=
"tooltip"
title=
"{% trans "
Copy
"
%}"
>
<span
class=
"far fa-copy"
></span>
</a>
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
sign in
to comment