Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
EvaP
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
CourseEval
EvaP
Commits
cbc2bf90
Commit
cbc2bf90
authored
Sep 20, 2021
by
Johannes Wolf
Browse files
Options
Downloads
Patches
Plain Diff
fix empty forms in evaluation edit throwing errors
parent
63b3d05f
Branches
Branches containing commit
No related tags found
No related merge requests found
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
evap/evaluation/templates/evap_evaluation_edit_js.html
+2
-2
2 additions, 2 deletions
evap/evaluation/templates/evap_evaluation_edit_js.html
evap/evaluation/templates/sortable_form_js.html
+0
-4
0 additions, 4 deletions
evap/evaluation/templates/sortable_form_js.html
with
2 additions
and
6 deletions
evap/evaluation/templates/evap_evaluation_edit_js.html
+
2
−
2
View file @
cbc2bf90
...
...
@@ -12,8 +12,8 @@
questionnaireChanged
=
true
;
})
roleChanged
=
!
row
.
find
(
"
input[id$=-role_0]
"
).
p
arent
().
hasClass
(
"
active
"
);
commVisibilityChanged
=
!
row
.
find
(
"
input[id$=_visibility_0]
"
).
p
arent
().
hasClass
(
"
active
"
);
roleChanged
=
!
row
.
find
(
"
input[id$=-role_0]
"
).
p
rop
(
"
checked
"
);
commVisibilityChanged
=
!
row
.
find
(
"
input[id$=_visibility_0]
"
).
p
rop
(
"
checked
"
);
labelChanged
=
row
.
find
(
"
input[id$=-label]
"
).
val
();
return
idChanged
||
nameChanged
||
questionnaireChanged
||
roleChanged
||
commVisibilityChanged
||
labelChanged
;
...
...
This diff is collapsed.
Click to expand it.
evap/evaluation/templates/sortable_form_js.html
+
0
−
4
View file @
cbc2bf90
...
...
@@ -27,9 +27,6 @@
// Checkboxes with 'data-keep' need to stay checked.
row
.
find
(
"
input:checkbox:not([data-keep]),:radio
"
).
removeAttr
(
"
checked
"
);
//Disable active buttons from bootstrap button groups
row
.
find
(
"
label
"
).
removeClass
(
"
active
"
);
row
.
find
(
"
input:text,textarea
"
).
val
(
""
);
row
.
find
(
"
select
"
).
each
(
function
(){
...
...
@@ -41,7 +38,6 @@
row
.
find
(
"
.btn-group
"
).
each
(
function
()
{
var
inputs
=
$
(
this
).
find
(
"
input
"
);
$
(
inputs
[
0
]).
prop
(
"
checked
"
,
true
);
$
(
inputs
[
0
]).
parent
().
addClass
(
"
active
"
);
});
//Remove all error messages
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
sign in
to comment