Added debugging statements to exec client requests

Assignment-06/starter/rsh_server.c

@@ -308,32 +308,26 @@ int exec_client_requests(int cli_socket) {
     ssize_t recv_bytes;
     int rc = OK;
 
-    while (1) {
+    printf("Waiting for client command...\n");
+
+    // Receive the command from the client
     recv_bytes = recv(cli_socket, cmd_buff, RDSH_COMM_BUFF_SZ, 0);
     if (recv_bytes <= 0) {
+        perror("recv");
         close(cli_socket);
-            printf("Client disconnected\n");
-            return OK;
+        return ERR_RDSH_COMMUNICATION;
     }
 
     cmd_buff[recv_bytes] = '\0';
+    printf("Received command: %s\n", cmd_buff);
 
-        cmd_buff[strcspn(cmd_buff, "\n")] = '\0';
-
-        if (strlen(cmd_buff) == 0) {
-            send_message_string(cli_socket, CMD_WARN_NO_CMD);
-            send_message_eof(cli_socket);
-            rc = WARN_NO_CMDS;
-            continue;
-        }
-
+    // Execute the command
     if (strstr(cmd_buff, "|") != NULL) {
+        // Handle pipeline commands
         command_list_t cmd_list;
         if (parse_pipeline(cmd_buff, &cmd_list) != OK) {
-                send_message_string(cli_socket, CMD_ERR_PIPE_LIMIT);
-                send_message_eof(cli_socket);
-                rc = ERR_TOO_MANY_COMMANDS;
-                continue;
+            fprintf(stderr, "Error parsing pipeline\n");
+            return ERR_TOO_MANY_COMMANDS;
         }
 
         rc = rsh_execute_pipeline(cli_socket, &cmd_list);
@@ -342,67 +336,70 @@ int exec_client_requests(int cli_socket) {
             free(cmd_list.commands[i]._cmd_buffer);
         }
     } else {
+        // Handle single commands
         cmd_buff_t cmd;
         if (build_cmd_buff(cmd_buff, &cmd) != OK) {
-                send_message_string(cli_socket, CMD_ERR_PIPE_LIMIT);
-                send_message_eof(cli_socket);
-                rc = ERR_MEMORY;
-                continue;
+            fprintf(stderr, "Error building command buffer\n");
+            return ERR_MEMORY;
         }
 
         if (strcmp(cmd.argv[0], EXIT_CMD) == 0) {
             free(cmd._cmd_buffer);
-                send_message_string(cli_socket, "Exiting...\n");
-                send_message_eof(cli_socket);
+            printf("Client requested exit\n");
             return OK;
         } else if (strcmp(cmd.argv[0], "cd") == 0) {
+            // Handle cd command
             if (cmd.argc == 1) {
                 chdir(getenv("HOME"));
             } else if (cmd.argc == 2) {
                 if (chdir(cmd.argv[1]) != 0) {
-                        char error_msg[256];
-                        snprintf(error_msg, sizeof(error_msg), "cd: %s\n", strerror(errno));
-                        send_message_string(cli_socket, error_msg);
+                    perror("cd");
                 }
             } else {
-                    send_message_string(cli_socket, CMD_ERR_PIPE_LIMIT);
+                fprintf(stderr, "cd: too many arguments\n");
             }
-                send_message_eof(cli_socket);
             free(cmd._cmd_buffer);
-                continue;
+            return OK;
         }
 
+        // Fork and execute the command
         pid_t pid = fork();
         if (pid < 0) {
             perror("fork failed");
-                rc = ERR_MEMORY;
+            return ERR_MEMORY;
         } else if (pid == 0) {
+            // Child process: execute the command
+            dup2(cli_socket, STDOUT_FILENO);  // Redirect stdout to client socket
+            dup2(cli_socket, STDERR_FILENO);  // Redirect stderr to client socket
             execvp(cmd.argv[0], cmd.argv);
             perror("execvp failed");
             exit(EXIT_FAILURE);
         } else {
+            // Parent process: wait for the child to finish
             int status;
             wait(&status);
 
             if (WIFEXITED(status)) {
                 if (WEXITSTATUS(status) != 0) {
-                        char error_msg[256];
-                        snprintf(error_msg, sizeof(error_msg), "Command failed with exit code %d\n", WEXITSTATUS(status));
-                        send_message_string(cli_socket, error_msg);
+                    fprintf(stderr, "Command failed with exit code %d\n", WEXITSTATUS(status));
                 }
             }
         }
+
         free(cmd._cmd_buffer);
     }
+
+    // Send EOF to indicate end of response
     send_message_eof(cli_socket);
-    }
 
+    printf("Command executed successfully\n");
     return rc;
 }
 
 
 
 
+
 /*
  * send_message_eof(cli_socket)
  *      cli_socket:  The server-side socket that is connected to the client